Fix extra rollbacks on pre-spawned entities #815
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I noticed several issues that were causing rollbacks:
SpawnHistory
set, and then I would add the same value again in theUpdateHistory
set. This wasn't an issue when we used heaps for the history component, but now that we switched to linked-lists this was causing issuesspawn_prespawned_history
system was running before the physics systems. That means that some components (LinearVelocity, etc.) that are added by avian would only have a history from the following tick, which was causing extra rollbacks.With this PR, I notice almost no rollbacks when launching bullets in the spaceships example!